This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Remove azure resourceGroupClient from backend initialisation. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… advantages : - less dependencies to init backend. (Will need to work more on this to make login command not need an existing subscription ID) - backend does not get login token at init time. For a long running process (grace server) this would cause issues with token lifetime - we benefit from the client config (polling options especially) set in aci.go, without duplicating stuff
rumpl
approved these changes
May 28, 2020
|
Yes, a common azure client struct would regroup code and avoid separate functions like this, will look into this in follow up PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
azure resourceGroupClient is now obtained lazily instead of being initialised when creating azure Backend.
Several advantages :
(not mandatory) A picture of a cute animal, if possible in relation with what you did
