Replace custom popup with Semantic UI Popup component#15
Open
Conversation
Wrap CalendarEvent with Semantic UI React's Popup component to show event details (title, location, time range) on hover. Removes the unused custom .calendar__event__popup CSS in favor of Semantic UI's built-in popup styling. https://claude.ai/code/session_01SRnHfqEX321LqcSCW24ymd
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The semantic-ui-react Popup component is incompatible with React 19 (uses deprecated findDOMNode). Use Semantic UI CSS classes (.ui.popup) with React state instead, matching the rest of the codebase's pattern. https://claude.ai/code/session_01SRnHfqEX321LqcSCW24ymd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the CalendarEvent component to use Semantic UI's
Popupcomponent instead of a custom popup implementation, improving code maintainability and consistency with the existing UI framework.Key Changes
Popupimport fromsemantic-ui-reactPopupcomponent.calendar__event__popupCSS styling that is no longer neededstart - endformat)Implementation Details
position="top center",size="small", andhoverableprops for optimal UXnumberToTimeutility functionhttps://claude.ai/code/session_01SRnHfqEX321LqcSCW24ymd