Make admin work with embedded field and arrayfield for django 3.2 #675
+470,786
−3,456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved testing
Pymongo has its own version of bson, which is incompatible with the package Dataclasses is included for versions over python 3.6, making it unnecessary to install
Bug fixes and other improvements
Previous versions of django ran a foreign key lookup with a const (1) parameter in the column list. Django 4 changed that to a parameterized value and pass the parameter value 1. I have created a new token type to hold the aliased paramaterized value. SQLConstParameterizedIdentifier is subclassed from SQLConstIdentifier, and the original functionality is broken out into SQLConstIntIdentifier. This should allow anything that was using isinstanceof for SQLConstIdentifier to still work and allows expansion to other non-int constants. A test case has been added for the django 4 select statement.
# Conflicts: # requirements.txt # setup.py
nesdis
force-pushed
the
master
branch
3 times, most recently
from
49a3eb5 to
ce0b58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with the fix from snphan however this still crashed with the array field. Digging a little deeper, I was unclear how the arrayfield was even being initialised.
This patch should fix the original issue, dict does not have _meta for embedded field, but also the list does not have _meta for the array field. Bit confused as to what the intended structure was for these forms but I have tested on a few of my own apps with version 3.2 in the admin and it appears to work fine.
This should address #624 but possibly a few other issues I saw open still.
Since I use this for a few projects, ill keep maintaining my fork until this is merged in/ fixed otherwise