-
Notifications
You must be signed in to change notification settings - Fork 41
Ajoute l'option Rich pour le DsfrRadioButtonSet #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajoute l'option Rich pour le DsfrRadioButtonSet #1133
Conversation
…ve-anchor fix: 🐛 utilisation native de l'ancre pour les liens d'évitement
✅ Deploy Preview for demo-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| validMessage: '', | ||
| legend: '', | ||
| hint: '', | ||
| rich: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C’est inutile, une propriété boolean est toujours false par défaut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai fait comme dans src/components/DsfrRadioButton/DsfrRadioButton.vue
Je suis censé faire quoi sinon ?
J'enlève simplement la ligne ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui, la ligne peut être supprimée
|
Il faut partir de |
17c75a7 to
d85a4d7
Compare
👷 Deploy request for vue-dsfr pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for docs-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
d85a4d7 to
9f1bb31
Compare
|
Il manque plus qu’un rebase de la branche à partir de develop (il ne devrait y avoir qu’un commit, et non 40 comme actuellement) |
|
Il manque toujours le rebase... |
|
J’ai intégré tes changements dans une autre PR. Je t’ai gardé en co-auteur |
Aujourd'hui il n'est pas possible de faire des radio input "rich" avec
DsfrRadioButtonSet