Skip to content

Conversation

@cprodhomme
Copy link
Contributor

Capture d’écran 2025-10-09 à 15 40 55

Aujourd'hui il n'est pas possible de faire des radio input "rich" avec DsfrRadioButtonSet

laruiss and others added 30 commits August 22, 2024 15:43
…ve-anchor

fix: 🐛 utilisation native de l'ancre pour les liens d'évitement
@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for demo-vue-dsfr ready!

Name Link
🔨 Latest commit 9f1bb31
🔍 Latest deploy log https://app.netlify.com/projects/demo-vue-dsfr/deploys/68ff6f46aad01600083d3622
😎 Deploy Preview https://deploy-preview-1133--demo-vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

validMessage: '',
legend: '',
hint: '',
rich: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’est inutile, une propriété boolean est toujours false par défaut

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai fait comme dans src/components/DsfrRadioButton/DsfrRadioButton.vue
Je suis censé faire quoi sinon ?
J'enlève simplement la ligne ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, la ligne peut être supprimée

laruiss
laruiss previously approved these changes Oct 21, 2025
@laruiss laruiss self-assigned this Oct 21, 2025
@laruiss
Copy link
Collaborator

laruiss commented Oct 21, 2025

Il faut partir de develop et demander la fusion dans develop cf. doc

@laruiss laruiss changed the base branch from main to develop October 21, 2025 15:50
@laruiss laruiss dismissed their stale review October 21, 2025 15:50

The base branch was changed.

@cprodhomme cprodhomme force-pushed the DsfrRadioButtonSet-with-rich-option branch from 17c75a7 to d85a4d7 Compare October 27, 2025 13:09
@netlify
Copy link

netlify bot commented Oct 27, 2025

👷 Deploy request for vue-dsfr pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9f1bb31

@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for docs-vue-dsfr ready!

Name Link
🔨 Latest commit 9f1bb31
🔍 Latest deploy log https://app.netlify.com/projects/docs-vue-dsfr/deploys/68ff6f4615aa4c000898064c
😎 Deploy Preview https://deploy-preview-1133--docs-vue-dsfr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cprodhomme cprodhomme force-pushed the DsfrRadioButtonSet-with-rich-option branch from d85a4d7 to 9f1bb31 Compare October 27, 2025 13:10
@laruiss
Copy link
Collaborator

laruiss commented Oct 30, 2025

Il manque plus qu’un rebase de la branche à partir de develop (il ne devrait y avoir qu’un commit, et non 40 comme actuellement)

@laruiss
Copy link
Collaborator

laruiss commented Nov 3, 2025

Il manque toujours le rebase...

@laruiss
Copy link
Collaborator

laruiss commented Nov 10, 2025

J’ai intégré tes changements dans une autre PR. Je t’ai gardé en co-auteur

@laruiss laruiss closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants