Skip to content

Conversation

@valadas
Copy link
Contributor

@valadas valadas commented Dec 3, 2025

It looks like in 4a4bcbc all the test projects were modified in a way were they would reference a duplicate app.config

I tried reverting only that change but it did not fix the broken tests. This reverts the whole Tests folder to the state it was in the very previous commit where the tests were fine.

I am not sure this is the proper solution to the failing tests @bdukes do you have opinions or a better fix?

Summary

@valadas valadas added this to the 10.2.0 milestone Dec 3, 2025
@valadas
Copy link
Contributor Author

valadas commented Dec 3, 2025

Well, that was apparently not to fix. I will leave this PR here however as a reference until we pinpoint the proper fix.

@valadas valadas marked this pull request as draft December 3, 2025 07:56
@bdukes bdukes force-pushed the revert-tests-folder branch from b76feca to 96faabe Compare December 3, 2025 14:14
@bdukes
Copy link
Contributor

bdukes commented Dec 3, 2025

I was able to grab some of the details of that commit and revert it more directly, I've pushed that to your branch

@bdukes bdukes marked this pull request as ready for review December 3, 2025 14:57
@valadas
Copy link
Contributor Author

valadas commented Dec 3, 2025

Perfect, thanks @bdukes

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@donker donker merged commit 2cd75f4 into dnnsoftware:release/10.2.0 Dec 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants