[WIP] First code submission for MVC Pipeline

.cursorignore

@@ -0,0 +1,30 @@
+node_modules/
+.env
+.env.local
+.env.development.local
+.env.test.local
+.env.production.local
+.DS_Store
+.idea/
+.vscode/
+.gitignore
+.git/
+.gitignore
+
+.vs/
+
+build/
+build.*
+.yarn/
+Artifacts/
+DotNetNuke.Internal.SourceGenerators/
+Install/
+tools/
+Website/
+.nuget/
+.github/
+Packages/
+Refs/
+tools/
+Dnn Platform/node_modules/
+Dnn Platform/Tests

.cursorrules

@@ -0,0 +1,72 @@
+
+# .NET Development Rules
+
+You are a senior .NET full stack developer and an expert in C#, ASP.NET Framework, ASP.NET Core, and ReactJS
+
+## This project
+
+This is a CMS that runs on classic ASP.NET Framework (version 4.8). The default entry point is /default.aspx which can be found under /DNN Platform/Website.
+We are building a new pipeline based on ASP.NET MVC with the goal of moving away from webforms and towards .NET Core. Right now we will create a hybrid solution
+with two rendering mechanisms: the old webforms pipeline through default.aspx and a new pipeline through /DesktopModules/Default/Page/{tabId}/{locale}. This
+should be picked up and handled in the DotNetNuke.Web.MvcPipeline library. The skin that is being loaded should decide which pipeline is being used to render a
+page to the client.
+
+## Code Organization
+
+We want to minimize any code changes to the existing project and concentrate as much as we can any code changes in the DotNetNuke.Web.MvcPipeline project.
+If need be we can create more projects to house new code.
+
+## Code Style and Structure
+ - Write concise, idiomatic C# code with accurate examples.
+ - Follow .NET and ASP.NET Core conventions and best practices.
+ - Use object-oriented and functional programming patterns as appropriate.
+ - Prefer LINQ and lambda expressions for collection operations.
+ - Use descriptive variable and method names (e.g., 'IsUserSignedIn', 'CalculateTotal').
+ - Structure files according to .NET conventions (Controllers, Models, Services, etc.).
+
+## Naming Conventions
+ - Follow guidelines from the stylecop.json file
+
+## C# and .NET Usage
+ -
+
+## Syntax and Formatting
+ - Use 'var' for implicit typing when the type is obvious.
+
+## Error Handling and Validation
+ - Use exceptions for exceptional cases, not for control flow.
+ - Implement proper error logging using built-in .NET logging or a third-party logger.
+ - Use Data Annotations or Fluent Validation for model validation.
+ - Implement global exception handling middleware.
+ - Return appropriate HTTP status codes and consistent error responses.
+
+## API Design
+ - Follow RESTful API design principles.
+ - Use attribute routing in controllers.
+ - Implement versioning for your API.
+ - Use action filters for cross-cutting concerns.
+
+## Performance Optimization
+ - Use asynchronous programming with async/await for I/O-bound operations.
+ - Implement caching strategies using IMemoryCache or distributed caching.
+ - Use efficient LINQ queries and avoid N+1 query problems.
+ - Implement pagination for large data sets.
+
+## Key Conventions
+ - Use Dependency Injection for loose coupling and testability.
+ - Implement repository pattern.
+ - Use AutoMapper for object-to-object mapping if needed.
+ - Implement background tasks using IHostedService or BackgroundService.
+
+## Testing
+ - Write unit tests using xUnit, NUnit, or MSTest.
+ - Use Moq or NSubstitute for mocking dependencies.
+ - Implement integration tests for API endpoints.
+
+## Security
+ - Implement proper CORS policies.
+
+## API Documentation
+ - Provide XML comments for controllers and models.
+
+Follow the official Microsoft documentation and ASP.NET MVC guides for best practices in routing, controllers, models, and other API components.

Build/Build.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <PackAsTool>true</PackAsTool>
     <!-- Make sure start same folder .NET Core CLI and Visual Studio -->
     <RunWorkingDirectory>$(MSBuildProjectDirectory)</RunWorkingDirectory>
@@ -15,17 +15,17 @@
     <AdditionalFiles Include="..\stylecop.json" Link="stylecop.json" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Cake.BuildSystems.Module" Version="7.1.0" />
+    <PackageReference Include="Cake.BuildSystems.Module" Version="8.0.0" />
     <PackageReference Include="Cake.FileHelpers" Version="7.0.0" />
-    <PackageReference Include="Cake.Frosting" Version="5.0.0" />
+    <PackageReference Include="Cake.Frosting" Version="6.0.0" />
     <PackageReference Include="Cake.Frosting.Git" Version="5.0.1" />
-    <PackageReference Include="Cake.Issues" Version="5.5.0" />
-    <PackageReference Include="Cake.Frosting.Issues.MsBuild" Version="5.5.0" />
+    <PackageReference Include="Cake.Issues" Version="5.9.1" />
+    <PackageReference Include="Cake.Frosting.Issues.MsBuild" Version="5.9.1" />
     <PackageReference Include="Cake.Json" Version="7.0.1" />
     <PackageReference Include="Cake.XdtTransform" Version="2.0.0" />
     <PackageReference Include="Dnn.CakeUtils" Version="2.1.0" />
-    <PackageReference Include="Microsoft.Data.SqlClient" Version="6.0.1" />
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
+    <PackageReference Include="Microsoft.Data.SqlClient" Version="6.1.3" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

Build/BuildScripts/Module.build

@@ -18,7 +18,7 @@
       <Images Include="Images/*.*" />
       <Keys Include="keys/*.*" />
       <ClientScripts Include="ClientScripts/*.*" />
-      <JsFiles Include="js/*.*" />
+      <JsFiles Include="js/*.*;*.js" />
       <Scripts Include="Scripts/*.*" />
       <SharedScripts Include="Scripts/Shared/*.*" />
       <Templates Include="Templates/*.htm" />

Build/ContextExtensions.cs

@@ -4,8 +4,9 @@
 
 namespace DotNetNuke.Build;
 
+using System;
 using System.Diagnostics;
-
+
 using Cake.Common.IO;
 using Cake.Core.IO;
 
@@ -18,6 +19,8 @@ public static class ContextExtensions
     /// <returns>The file version.</returns>
     public static string GetAssemblyFileVersion(this Context context, FilePath assemblyPath)
     {
-        return FileVersionInfo.GetVersionInfo(context.MakeAbsolute(assemblyPath).FullPath).FileVersion;
+        var versionInfo = FileVersionInfo.GetVersionInfo(context.MakeAbsolute(assemblyPath).FullPath);
+        var fileVersion = versionInfo.FileVersion;
+        return Version.TryParse(fileVersion, out _) ? fileVersion : $"{versionInfo.FileMajorPart}.{versionInfo.FileMinorPart}.{versionInfo.FileBuildPart}";
     }
 }

Build/LocalSettings.cs

@@ -33,6 +33,9 @@ public class LocalSettings
         /// <summary>Gets or sets the path to the database files.</summary>
         public string DatabasePath { get; set; } = string.Empty;
 
+        /// <summary>Gets or sets a value indicating whether to copy the sample projects to the build output.</summary>
+        public bool CopySampleProjects { get; set; } = false;
+
         /// <summary>Gets or sets the version to use for the build.</summary>
         public string Version { get; set; } = "auto";
     }

Build/Tasks/BuildToTempFolder.cs

@@ -3,10 +3,10 @@
 // See the LICENSE file in the project root for more information
 namespace DotNetNuke.Build.Tasks
 {
-    using System;
-    using System.Linq;
-
+    using Cake.Common.Diagnostics;
+    using Cake.Common.IO;
     using Cake.Frosting;
+    using Dnn.CakeUtils;
 
     /// <summary>A cake task to build the platform.</summary>
     [IsDependentOn(typeof(SetVersion))]
@@ -16,5 +16,20 @@ namespace DotNetNuke.Build.Tasks
     [IsDependentOn(typeof(OtherPackages))]
     public sealed class BuildToTempFolder : FrostingTask<Context>
     {
+        /// <inheritdoc/>
+        public override void Run(Context context)
+        {
+            if (context.Settings.CopySampleProjects)
+            {
+                context.Information("Copying Sample Projects to Temp Folder");
+                var files = context.GetFilesByPatterns(context.ArtifactsFolder, new[] { "SampleModules/*.zip" });
+                foreach (var file in files)
+                {
+                    var destination = context.File(System.IO.Path.Combine(context.WebsiteFolder, "Install", "Module", file.GetFilename().ToString()));
+                    context.CopyFile(file, destination);
+                    context.Information($"  Copied {file.GetFilename()} to {destination}");
+                }
+            }
+        }
     }
 }

Build/Tasks/OtherPackages.cs

@@ -18,6 +18,7 @@ namespace DotNetNuke.Build.Tasks
     /// <summary>A cake task to include other 3rd party packages.</summary>
     [IsDependentOn(typeof(PackageNewtonsoft))]
     [IsDependentOn(typeof(PackageMailKit))]
+    [IsDependentOn(typeof(PackageHtmlSanitizer))]
     [IsDependentOn(typeof(PackageAspNetWebApi))]
     [IsDependentOn(typeof(PackageAspNetWebPages))]
     [IsDependentOn(typeof(PackageAspNetMvc))]

Build/Tasks/PackageHtmlSanitizer.cs

@@ -0,0 +1,14 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information
+namespace DotNetNuke.Build.Tasks;
+
+/// <summary>A cake task to generate the MailKit package.</summary>
+public sealed class PackageHtmlSanitizer : PackageComponentTask
+{
+    /// <summary>Initializes a new instance of the <see cref="PackageHtmlSanitizer"/> class.</summary>
+    public PackageHtmlSanitizer()
+        : base("HtmlSanitizer")
+    {
+    }
+}

Build/Tasks/packaging.json

@@ -36,6 +36,10 @@
     "/bin/System.Web.Http.dll",
     "/bin/System.Web.Http.WebHost.dll",
     "/bin/DotNetNuke.Web.Mvc.dll",
+
+	"/bin/DotNetNuke.Web.MvcPipeline.dll",
+	"/bin/DotNetNuke.Web.MvcWebsite.dll",
+
     "/bin/System.Web.Mvc.dll",
     "/bin/System.Web.Helpers.dll",
     "/bin/Microsoft.Web.Helpers.dll",

Build/Tasks/unversionedManifests.txt

@@ -1,8 +1,4 @@
-DNN Platform/Components/MailKit/*.dnn
-DNN Platform/Components/Microsoft.*/**/*.dnn
-DNN Platform/Components/Newtonsoft/*.dnn
-DNN Platform/Components/WebFormsMvp/*.dnn
-DNN Platform/Components/SharpZipLib/*.dnn
+DNN Platform/Components/**/*.dnn
 DNN Platform/JavaScript Libraries/HoverIntent/*.dnn
 DNN Platform/JavaScript Libraries/jQuery*/*.dnn
 DNN Platform/JavaScript Libraries/Knockout*/*.dnn

DNN Platform/Components/HtmlSanitizer/HtmlSanitizer.dnn

@@ -0,0 +1,55 @@
+<dotnetnuke type="Package" version="5.0">
+  <packages>
+    <package name="DotNetNuke.HtmlSanitizer" type="Library" version="1.0.0">
+      <friendlyName>HtmlSanitizer Components</friendlyName>
+      <description>Provides AngleSharp and HtmlSanitizer assemblies for the platform.</description>
+      <dependencies/>
+      <owner>
+        <name>.NET Foundation and Contributors</name>
+        <organization>DNN Community</organization>
+        <url>https://dnncommunity.org</url>
+        <email>[email protected]</email>
+      </owner>
+      <license src="License.txt"/>
+      <releaseNotes>
+        This package includes AngleSharp, AngleSharp.Css and HtmlSanitizer assemblies.
+      </releaseNotes>
+      <components>
+        <component type="Assembly">
+          <assemblies>
+            <assembly>
+              <path>bin</path>
+              <name>AngleSharp.dll</name>
+              <version />
+            </assembly>
+            <assembly>
+              <path>bin</path>
+              <name>AngleSharp.Css.dll</name>
+              <version />
+            </assembly>
+            <assembly>
+              <path>bin</path>
+              <name>HtmlSanitizer.dll</name>
+              <version />
+            </assembly>
+            <assembly>
+              <path>bin</path>
+              <name>System.Collections.Immutable.dll</name>
+              <version />
+            </assembly>
+            <assembly>
+              <path>bin</path>
+              <name>System.Text.Encoding.CodePages.dll</name>
+              <version />
+            </assembly>
+            <assembly>
+              <path>bin</path>
+              <name>System.Runtime.CompilerServices.Unsafe.dll</name>
+              <version/>
+            </assembly>
+          </assemblies>
+        </component>
+      </components>
+    </package>
+  </packages>
+</dotnetnuke>

DNN Platform/Components/HtmlSanitizer/License.txt

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (C) 2012-2020 .NET Foundation and Contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

DNN Platform/Components/Microsoft.AspNetMvc/Microsoft.AspNetMvc.dnn

@@ -17,6 +17,16 @@
           <assemblies>
             <assembly>
               <path>bin</path>
+              <name>DotNetNuke.Web.MvcPipeline.dll</name>
+              <version>0.0.1.0</version>
+            </assembly>
+			<assembly>
+              <path>bin</path>
+              <name>DotNetNuke.Web.MvcWebsite.dll</name>
+              <version>0.0.1.0</version>
+            </assembly>
+			<assembly>
+              <path>bin</path>
               <name>DotNetNuke.Web.Mvc.dll</name>
               <version>9.10.0</version>
             </assembly>

DNN Platform/DotNetNuke.Abstractions/Portals/IPortalSettings.cs

@@ -365,5 +365,8 @@ public interface IPortalSettings
 
         /// <summary>Gets a value indicating whether to display the dropdowns to quickly add a moduel to the page in the edit bar.</summary>
         bool ShowQuickModuleAddMenu { get; }
+
+        /// <summary>Gets the pipeline type for the portal.</summary>
+        string PagePipeline { get; }
     }
 }

DNN Platform/DotNetNuke.Abstractions/Portals/PagePipelineConstants.cs

@@ -0,0 +1,18 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information
+namespace DotNetNuke.Abstractions.Portals
+{
+    /// <summary>
+    /// Provides constants for the page pipelines used in the DNN platform,
+    /// such as WebForms and MVC.
+    /// </summary>
+    public static class PagePipelineConstants
+    {
+        /// <summary>WebForms.</summary>
+        public const string WebForms = "webforms";
+
+        /// <summary>MVC.</summary>
+        public const string Mvc = "mvc";
+    }
+}