[feat #186] 질문글 삭제 API #187
Open
+148
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
1 task
Code Coverage
|
Test Results 28 files 28 suites 14s ⏱️ Results for commit c92e825. |
dudxo
reviewed
Jan 5, 2025
| public DeleteQuestionPostResponse deleteQuestionPost( | ||
| Long questionPostId | ||
| ){ | ||
| QuestionPost questionPost = questionPostRepository.findById(questionPostId) |
There was a problem hiding this comment.
작성자 본인의 게시글이 맞는지 확인하는 유효성 검사가 누락 되어있습니다!
| ){ | ||
| QuestionPost questionPost = questionPostRepository.findById(questionPostId) | ||
| .orElseThrow(() -> new NotFoundException(QuestionPostErrorCode.NOT_FOUND_QUESTION_POST)); | ||
| if (answerRepository.existsByQuestionPostId(questionPostId)) { |
| }); | ||
| } | ||
|
|
||
| private void saveRefundCreditHistory(Member member, int reward){ |
|
|
||
| //when & then | ||
| assertThrows(ValidationException.class, | ||
| () -> questionPostService.deleteQuestionPost(questionPostId)); |
There was a problem hiding this comment.
삭제할 수 없을 때 발생하는 예외 문구가 의도와 맞는지 확인하면 더 좋은 테스트 코드가 될 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분
refundClosedQuestionPosts()로 수정했습니다.