Add shm-size and ipc-mode options to docker run script generation - #256
Open
bomquangia wants to merge 1 commit into
Open
Add shm-size and ipc-mode options to docker run script generation#256bomquangia wants to merge 1 commit into
bomquangia wants to merge 1 commit into
Conversation
Extends TaskCommandFileGenerator and the dockerRunScript SSP template with two new optional parameters: shmSize and ipcMode. When set, the generated docker run command includes --shm-size and --ipc flags respectively. Both default to None, leaving existing behavior unchanged. Flags are emitted as quoted direct argv tokens in the docker run invocation rather than through shell variable expansion, preventing shell-meta injection even if upstream validation were bypassed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskCommandFileGenerator.writeDockerRunScriptandapply:shmSizeandipcMode--shm-sizeand--ipcflags respectivelyNone; existing behavior is entirely unchanged when neither is provideddocker runline, not via shell variable expansionChanges
src/main/resources/templates/exec/dockerRunScript.ssp— conditional--shm-size/--ipctokens in thedocker runblocksrc/main/scala/wdlTools/exec/TaskExecutor.scala— optional params onwriteDockerRunScriptandapplysrc/test/scala/wdlTools/exec/TaskCommandFileGeneratorTest.scala— new test class with cases for all flag combinationsRELEASE_NOTES.md— changelog entryTest plan