-
Notifications
You must be signed in to change notification settings - Fork 68
[DQM] Prompt Matrix reconfiguration #4619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bcf0b37
Update ReplayOfflineConfiguration.py
jfernan2 80e5081
Update CMSSW version to CMSSW_12_1_0
germanfgv 9cb188b
Update runs and GTs
germanfgv 59dc6db
Set proper Scenarios and scram Arch
germanfgv 5599940
Update GTs to fix 'NoRecord' execption
germanfgv aea859e
New GTs
germanfgv 47ad2b0
Remove dtCalib and timemark
germanfgv fcdf35b
Link @hcal to @L1TMon due to dependencies recently introduced
jfernan2 3e59708
Merge branch 'master' into patch-3
jfernan2 9554226
Fix for issues found during last replay
jfernan2 4c99f5c
Merge branch 'master' into patch-3
jfernan2 b609841
MB to MB
jfernan2 61ad12d
Switched to CMSSW_12_1_1
jfernan2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfernan2 It looks like the replays is indeed ading DQM sequences to the MET dataset. Is this a mistake?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not a mistake, it was needed to avoid a new PR and a new release since @hcal sequence changed in between requesting a collection which is produced in @L1TMon. However, this sequence was already present in previous @common definition which run fine at Tier0 since Run1.
Please note that, @common has changed, so we dropped things in @common which are not needed anywhere else, but added @L1TMon where @hcal was present to preserve the compatibility. This was done in cms-sw/cmssw#35605 as explained in the PR description.
So, in practice, at the end we are not adding anything which were not there already, but dropping sequences.
Thanks