Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic HTTP Authentication for JIRA plugin #25

Merged
merged 1 commit into from
May 30, 2017
Merged

Add Basic HTTP Authentication for JIRA plugin #25

merged 1 commit into from
May 30, 2017

Conversation

Akasurde
Copy link
Contributor

Fixes #7

Signed-off-by: Abhijeet Kasurde [email protected]

Copy link
Owner

@dmranck dmranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not able to test it. It looks like my JIRA instance only works with Kerberos authentication. Do you have a JIRA instance I can run a quick functional test on?

>>> from ticketutil.jira import JiraTicket
>>> t = JiraTicket(<jira_url>,
<project_key>,
auth=(username='username', password='password'))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be:
auth=(<username>, <password>)

@Akasurde
Copy link
Contributor Author

@dmranck Done. You can test this PR using JIRA free instance.

@dmranck
Copy link
Owner

dmranck commented May 30, 2017

Works perfectly. Also +100 for getting me to sign up for my own JIRA instance - something I should have done a long time ago. :)

@dmranck dmranck merged commit d1727fa into dmranck:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants