Fix JD mode bridge dying on bad share submits - #283
Open
ANAMASGARD wants to merge 1 commit into
Open
Conversation
The bridge downstream handler previously exited on any submit-share failure, closing tx_sv1_bridge for all miners. Treat per-share errors as recoverable, only tear down on fatal channel failures, and improve error messages so Closed(..) is no longer misreported as a receive-task failure. Fixes dmnd-pool#127 Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #127
In JD mode, a single bad share submit could kill the bridge channel for every connected miner. Shares still validated locally, but upstream forwarding failed with a misleading
Closed(..)error that looked like a receive-task crash.This change keeps the bridge running for recoverable per-share errors (invalid job ID, translation failure, etc.) and only shuts down on real fatal failures (dead upstream/submit channels, poisoned mutex).
Also improves error messages so
Closed(..)is no longer reported as "Failed to start receive downstream task".Test plan
cargo test— 89 passedbridge_survives_repeated_invalid_job_submitsfatal_upstream_submit_channel_closes_bridge_downstream_handlerforward_submit_share_returns_bridge_channel_closed_when_receiver_dropped