fix(api): report admission saturation in /api/health without marking the proxy dead - #280
Open
ANAMASGARD wants to merge 1 commit into
Open
Conversation
Fixes dmnd-pool#244 Return HTTP 200 when the proxy is alive but at max active downstreams. Saturation is read from the ingress admission semaphore (ground truth), not handoff queue depth or stats.len(). Handoff backlog is exposed as a readiness field (handoff_backlog_full) instead of HTTP 503.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #244
When the proxy hits its max active downstream limit, it’s still healthy — it’s just not accepting new miners. Before this change,
/api/healthcould return 503 based on signals that don’t reflect real admission capacity (handoff queue depth or stats count). Load balancers and operators could treat a live, working proxy as dead and keep sending miners to it anyway.This PR separates liveness (“is the proxy up?”) from readiness (“can it take more miners?”):
Saturation is read from the ingress admission semaphore — the same gate that stops new TCP accepts when the proxy is full — not from the handoff queue (which drains quickly into background setup) or from
stats.len()(which can lag).What changed
handoff_backlog_full: truestats.len() >= max→ 503saturated: true(from semaphore)"Proxy OK"Example response when alive but at capacity:
{ "success": true, "data": { "status": "ok", "saturated": true, "handoff_backlog_full": false, "message": "Proxy is alive but admission saturated: not accepting new connections" } }