cherry-pick: JD debug logging from #162 (fixes #167) - #279
Open
ANAMASGARD wants to merge 3 commits into
Open
Conversation
Assisted-by: GitHub Copilot Assisted-by: OpenAI GPT-5.1-Codex
Assisted-by: GitHub Copilot Assisted-by: OpenAI GPT-5.1-Codex
Decode the reason so the log is human readable. Assisted-by: GitHub Copilot Assisted-by: OpenAI GPT-5.1-Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the three logging commits from closed #162 as requested in #167.
Commits included
e853948— Log ProvideMissingTransactions responses221592b— Log template transaction counts3a8346f— Decode "Job is not verified" reason into readable logsCommits excluded (per @jbesraa feedback on #162)
7916d6c— position validation loop (latency concern)0ce6d5a— requested txid logging (feature flag concern)What this does
debug!when sending ProvideMissingTransactionsSuccess (request_id + tx count)debug!when receiving template transaction lists (template_id + tx_count)ErrorDetailshelpererror!logging for "Job is not verified" and DeclareMiningJobErrorWhat this does NOT do
Conflict notes
221592band3a8346fwere manually merged against current master (prioritized-tx logic inon_new_templatewas preserved).Test plan
cargo build— passedcargo test— 86 passed, 0 failed (79 lib + 6 integration + 1 library_init)Screenshots attached.
Fixes #167
Cherry-picked from #162