SYCL. Fixes for the upcoming v3.1 #11725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look into merging this and check whether it's possible to backport. cc @hcho3 |
hcho3
reviewed
Oct 6, 2025
There was a problem hiding this comment.
The changes look benign. However, I'm a bit concerned about the increased complexity for device dispatching logic in the main code base; now the CPU updater needs to call IsSycl(), even when the CPU updater has nothing to do with SYCL.
Is it possible to make ctx_->Device() decay gracefully to cpu when called inside a CPU updater?
|
That make sense. I plan to create sycl-specific implementations for all requared parts, it would allow to remove all this checks like |
hcho3
approved these changes
Oct 8, 2025
trivialfis
approved these changes
Oct 9, 2025
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Oct 10, 2025
--------- Co-authored-by: Dmitry Razdoburdin <>
trivialfis
added a commit
that referenced
this pull request
Oct 11, 2025
--------- Co-authored-by: Dmitry Razdoburdin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This massive PR contains the main part of sycl-related fixes for the upcoming xgboost 3.1.
I have tried to make as little changes in the main part of the code as possible.