Skip to content

Conversation

jakirkham
Copy link
Contributor

Backports to XGBoost 3.0.x PR: #11351

Make sure to search for RMM if it will be used. This should pick up the patched CCCL from RMM.

If RMM is not being used and this is a CUDA build, search for CCCL explicitly.

Make sure to search for RMM if it will be used. This should pick up the
patched CCCL from RMM.

If RMM is not being used and this is a CUDA build, search for CCCL
explicitly.
@jakirkham
Copy link
Contributor Author

cc @trivialfis

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once the CI is green.

@jakirkham
Copy link
Contributor Author

Thanks Jiaming! 🙏

Sounds good


For the one Windows failure am just seeing this:

Screenshot 2025-03-20 at 10 04 55 AM

Is there somewhere we should be looking for logs?

@jakirkham
Copy link
Contributor Author

jakirkham commented Mar 20, 2025

Most CI runs pass. Seeing a couple CI failures when running the test suite. However that is well after the change here. So think they may not be related

Edit - Note the RMM builds do pass and pick up RMM's CCCL:

-- Found Thrust: /opt/rmm/lib64/rapids/cmake/thrust/thrust-config.cmake (found suitable exact version "2.5.0.0")
-- Found CCCL: /opt/rmm/lib64/rapids/cmake/cccl/cccl-config.cmake (found version "2.5.0.0")
-- Found nvtx3: /opt/rmm/lib64/cmake/nvtx3/nvtx3-config.cmake (found version "3.1.0")
-- Found rmm: /opt/rmm/lib64/cmake/rmm/rmm-config.cmake (found version "24.12.0")

@trivialfis trivialfis merged commit 24f683e into dmlc:release_3.0.0 Mar 20, 2025
78 of 85 checks passed
@jakirkham jakirkham deleted the search_rmm_then_cccl_30x branch March 20, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants