Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[TVM][BUGFIX] Change graph_runtime to graph_executor & Fix MosesNormalizer #1547

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Apr 12, 2021

Description

TVM will deprecate graph_runtime and use graph_executor. https://github.com/apache/tvm/blob/bf862d4c4355eae4f18d89b3b6b98ed0a2c18e9c/python/tvm/contrib/graph_runtime.py#L24-L29

When building gpu docker, the log shows

Defaulting to user installation because normal site-packages is not writeable
Looking in links: https://download.pytorch.org/whl/torch_stable.html
ERROR: Could not find a version that satisfies the requirement torch==1.7.1+cu102
ERROR: No matching distribution found for torch==1.7.1+cu102

So, I changed to torch==1.8.1+cu102 @leezu
Also fix sacremoses version to <0.0.44, because the contributors of sacremoses didn't update their release for 0.0.44 on github. Updates will be tracked in #1548

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@barry-jin barry-jin requested a review from a team as a code owner April 12, 2021 17:59
@github-actions
Copy link

@leezu
Copy link
Contributor

leezu commented Apr 12, 2021

FYI @xinyual this should fix the issue you met

@barry-jin barry-jin changed the title [TVM] Change graph_runtime to graph_executor [TVM][BUGFIX] Change graph_runtime to graph_executor & Fix MosesNormalizer Apr 12, 2021
@github-actions
Copy link

setup.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1547 (7757078) into master (1326258) will decrease coverage by 2.96%.
The diff coverage is n/a.

❗ Current head 7757078 differs from pull request most recent head d45acfc. Consider uploading reports for the commit d45acfc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
- Coverage   82.20%   79.23%   -2.97%     
==========================================
  Files          68       68              
  Lines        8540     8540              
==========================================
- Hits         7020     6767     -253     
- Misses       1520     1773     +253     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/gluonnlp/utils/testing.py 58.33% <0.00%> (-35.84%) ⬇️
src/gluonnlp/models/xlmr.py 58.82% <0.00%> (-29.42%) ⬇️
src/gluonnlp/models/electra.py 58.47% <0.00%> (-18.37%) ⬇️
src/gluonnlp/utils/config.py 61.53% <0.00%> (-15.39%) ⬇️
src/gluonnlp/models/bart.py 78.75% <0.00%> (-15.00%) ⬇️
src/gluonnlp/models/roberta.py 84.25% <0.00%> (-9.37%) ⬇️
src/gluonnlp/models/bert.py 87.54% <0.00%> (-7.27%) ⬇️
src/gluonnlp/models/gpt2.py 91.00% <0.00%> (-7.27%) ⬇️
src/gluonnlp/embedding/embed_loader.py 75.79% <0.00%> (-5.74%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1326258...d45acfc. Read the comment docs.

@leezu leezu merged commit 5ff0519 into dmlc:master Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants