Repository navigation
feat(symbols): add --sympath-append to search local directories for PDBs - #30
Merged
Merged
Conversation
Add a repeatable --sympath-append <PATH> CLI option that appends local directories to the symbol path. ntoseye looks for PDB files in these directories—both bare (e.g. dir/driver.pdb) and in symbol-store layout (dir/driver.pdb/GUID/driver.pdb)—during symbol resolution. This is useful for loading PDBs built locally, such as those produced by the kvm-guest-drivers-windows build under its Install/ directory, without copying them into the managed symbol cache or standing up a symbol server.
dmaivel
added a commit
that referenced
this pull request
Oct 7, 2026
Clap replaces a global option's values from before the subcommand with those after it, even when the option appends. `ntoseye --pdb-server a mcp --pdb-server b` therefore searched only server b, silently. The parsing that #30 added for --sympath-append already works around this, so apply it to every repeatable target option instead of one. Verified: cargo fmt --check and both clippy configurations are clean; the accumulation test now covers --pdb-server and passes; an MCP server started with a server and a directory on each side of `mcp` listed all four in command-line order in `.sympath` against the live guest.
dmaivel
added a commit
that referenced
this pull request
Oct 7, 2026
#30 added the option without prose docs or a changelog line. The symbols guide said the start-up path ends at Microsoft's server, and the troubleshooting page told users to replace the whole path with .sympath to use local PDBs, where .sympath+ or the new option keeps the cache and servers. The guide also now says that local directories are searched before any server, since `.sympath` lists the appended directories last and that order reads as if they came after a download. Verified: sphinx-build -n -W, parse-changelog, both clippy configurations, cargo check for the server features, cargo test --lib (1035), the Python stub (unchanged), mypy --strict, pytest, and the live suite (33 passed) all pass; the built command-line reference, symbols guide and changelog show the option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a repeatable --sympath-append CLI option that appends local directories to the symbol path. ntoseye looks for PDB files in these directories—both bare (e.g. dir/driver.pdb) and in symbol-store layout (dir/driver.pdb/GUID/driver.pdb)—during symbol resolution.
This is useful for loading PDBs built locally, such as those produced by the kvm-guest-drivers-windows build under its Install/ directory, without copying them into the managed symbol cache or standing up a symbol server.