make some classes final (#35)

src/DAMAMenuBundle.php

@@ -6,10 +6,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
-/**
- * @final
- */
-class DAMAMenuBundle extends Bundle
+final class DAMAMenuBundle extends Bundle
 {
     public function build(ContainerBuilder $container): void
     {

src/DependencyInjection/CompilerPass/NodeVisitorCompilerPass.php

@@ -7,10 +7,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 
-/**
- * @final
- */
-class NodeVisitorCompilerPass implements CompilerPassInterface
+final class NodeVisitorCompilerPass implements CompilerPassInterface
 {
     use PriorityTaggedServiceTrait;
 

src/DependencyInjection/Configuration.php

@@ -5,10 +5,7 @@
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
-/**
- * @final
- */
-class Configuration implements ConfigurationInterface
+final class Configuration implements ConfigurationInterface
 {
     public function getConfigTreeBuilder(): TreeBuilder
     {

src/DependencyInjection/DAMAMenuExtension.php

@@ -8,10 +8,7 @@
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 
-/**
- * @final
- */
-class DAMAMenuExtension extends Extension
+final class DAMAMenuExtension extends Extension
 {
     public const NODE_FACTORY_SERVICE_ID_PREFIX = 'dama_menu.node_factory.custom.';
     public const TREE_BUILDER_SERVICE_ID_PREFIX = 'dama_menu.tree_builder.custom.';

src/Menu/MenuFactory.php

@@ -8,25 +8,22 @@
 use DAMA\MenuBundle\Node\Node;
 use DAMA\MenuBundle\Node\NodeFactoryInterface;
 
-/**
- * @final
- */
-class MenuFactory implements MenuFactoryInterface
+final class MenuFactory implements MenuFactoryInterface
 {
     /**
      * @var MenuConfigProvider
      */
-    protected $menuConfigProvider;
+    private $menuConfigProvider;
 
     /**
      * @var MenuTreeTraverserInterface
      */
-    protected $menuTreeTraverser;
+    private $menuTreeTraverser;
 
     /**
      * @var array<string, Node>
      */
-    protected $cache = [];
+    private $cache = [];
 
     public function __construct(MenuConfigProvider $menuConfigProvider, MenuTreeTraverserInterface $menuTreeTraverser)
     {
@@ -53,7 +50,7 @@ public function create(string $name): Node
         return $root;
     }
 
-    protected function getRootNode(NodeFactoryInterface $nodeFactory, MenuTreeBuilderInterface $menuTreeBuilder): Node
+    private function getRootNode(NodeFactoryInterface $nodeFactory, MenuTreeBuilderInterface $menuTreeBuilder): Node
     {
         $root = $nodeFactory->create(null);
         $menuTreeBuilder->build($root);

src/MenuConfig/MenuConfigProvider.php

@@ -2,15 +2,12 @@
 
 namespace DAMA\MenuBundle\MenuConfig;
 
-/**
- * @final
- */
-class MenuConfigProvider
+final class MenuConfigProvider
 {
     /**
      * @var array<string, array>
      */
-    protected $configs = [];
+    private $configs = [];
 
     /**
      * @param array<string, mixed> $config

src/MenuTree/MenuTreeTraverser.php

@@ -5,15 +5,12 @@
 use DAMA\MenuBundle\Node\Node;
 use DAMA\MenuBundle\NodeVisitor\NodeVisitorInterface;
 
-/**
- * @final
- */
-class MenuTreeTraverser implements MenuTreeTraverserInterface
+final class MenuTreeTraverser implements MenuTreeTraverserInterface
 {
     /**
      * @var NodeVisitorInterface[]
      */
-    protected $visitors = [];
+    private $visitors = [];
 
     public function traverse(Node $node): void
     {

src/Node/NodeFactory.php

@@ -2,10 +2,7 @@
 
 namespace DAMA\MenuBundle\Node;
 
-/**
- * @final
- */
-class NodeFactory implements NodeFactoryInterface
+final class NodeFactory implements NodeFactoryInterface
 {
     public function create(?string $label = null): Node
     {

src/NodeVisitor/NodeActivator.php

@@ -7,15 +7,13 @@
 
 /**
  * This visitor will set a node to active if one of its routes matches the current route of the request.
- *
- * @final
  */
-class NodeActivator implements NodeVisitorInterface
+final class NodeActivator implements NodeVisitorInterface
 {
     /**
      * @var RequestStack
      */
-    protected $requestStack;
+    private $requestStack;
 
     public function __construct(RequestStack $requestStack)
     {

src/NodeVisitor/NodeFilter.php

@@ -9,10 +9,8 @@
 
 /**
  * This visitor will remove the node from the tree if not all necessary permissions are granted.
- *
- * @final
  */
-class NodeFilter implements NodeVisitorInterface
+final class NodeFilter implements NodeVisitorInterface
 {
     /**
      * @var TokenStorageInterface

src/NodeVisitor/NodeRoutePropagator.php

@@ -6,10 +6,8 @@
 
 /**
  * This visitor will propagate the route of the current node to the direct parent if it does not have a route yet.
- *
- * @final
  */
-class NodeRoutePropagator implements NodeVisitorInterface
+final class NodeRoutePropagator implements NodeVisitorInterface
 {
     /**
      * {@inheritdoc}

src/Twig/MenuExtension.php

@@ -5,10 +5,7 @@
 use Twig\Extension\AbstractExtension;
 use Twig\TwigFunction;
 
-/**
- * @final
- */
-class MenuExtension extends AbstractExtension
+final class MenuExtension extends AbstractExtension
 {
     public function getFunctions(): array
     {

src/Twig/MenuRuntime.php

@@ -9,10 +9,7 @@
 use Twig\Extension\RuntimeExtensionInterface;
 use Twig\TemplateWrapper;
 
-/**
- * @final
- */
-class MenuRuntime implements RuntimeExtensionInterface
+final class MenuRuntime implements RuntimeExtensionInterface
 {
     /**
      * @var Environment

tests/Menu/MenuFactoryTest.php

@@ -29,7 +29,7 @@ public function setUp(): void
     {
         $this->nodeFactory = $this->createMock(NodeFactoryInterface::class);
         $this->treeBuilder = $this->createMock(MenuTreeBuilderInterface::class);
-        $this->menuConfigProvider = $this->createMock(MenuConfigProvider::class);
+        $this->menuConfigProvider = new MenuConfigProvider();
         $this->menuTreeTraverser = $this->createMock(MenuTreeTraverserInterface::class);
 
         $this->menuFactory = new MenuFactory($this->menuConfigProvider, $this->menuTreeTraverser);
@@ -49,13 +49,10 @@ public function testCreate(): void
         ;
 
         $this->menuConfigProvider
-            ->expects($this->once())
-            ->method('getMenuConfig')
-            ->with('name')
-            ->will($this->returnValue([
+            ->addMenuConfig('name', [
                 'tree_builder' => $this->treeBuilder,
                 'node_factory' => $this->nodeFactory,
-            ]))
+            ])
         ;
 
         $this->menuTreeTraverser