Cold boot fixes - #193
Draft
Lawstorant wants to merge 7 commits into
Draft
Conversation
This reverts commit 7ee0ce1.
gip_headset_advance_pointer() compared a byte counter (stream->period, incremented by the packet payload length in bytes) against runtime->period_size, which is in frames. For S16_LE mono (2 bytes/frame), snd_pcm_period_elapsed() fired at twice the correct rate; for stereo it fired at four times the correct rate. Use snd_pcm_lib_period_bytes() to get the period size in bytes, matching the unit of the counter. (cherry picked from commit 90a6757)
usb_get_from_anchor removes the URB from the idle anchor and takes a reference. If the subsequent skb allocation fails, the URB was leaked — neither re-anchored nor freed. Over time under memory pressure this permanently loses output URBs, making the dongle unable to send data to controllers. Re-anchor the URB and drop the reference before returning -ENOMEM. (cherry picked from commit ef70379)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.