Adding sql dialect to destination capabilities #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
reviewed
Mar 11, 2025
| if dialect.name == "mysql" or backend_name in ("mysql", "mariadb"): | ||
| # correct max identifier length | ||
| # dialect uses 255 (max length for aliases) instead of 64 (max length of identifiers) | ||
| caps.max_identifier_length = 64 | ||
| caps.format_datetime_literal = _format_mysql_datetime_literal | ||
| caps.sqlglot_dialect = "mysql" | ||
|
|
||
| elif backend_name in [ |
sh-rp
requested changes
Mar 11, 2025
anuunchin
force-pushed
the
feat/2392-sqlglot-dialect
branch
from
e9e1e01 to
cfd82cc
Compare
anuunchin
force-pushed
the
feat/2392-sqlglot-dialect
branch
from
e427b57 to
268287a
Compare
anuunchin
commented
Mar 13, 2025
|
The tables in the PR description are also updated - dialects for certain destinations (synapse, dremio, motherduck) were marked as working in |
sh-rp
reviewed
Mar 13, 2025
|
The clickhouse and databricks dialects are supported by ibis. |
…sql is the same as mssql.
anuunchin
force-pushed
the
feat/2392-sqlglot-dialect
branch
from
4c7779f to
a80921e
Compare
rudolfix
requested changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds sqlglot client to destination capabilities where possible. Special treatment for sqlalchemy destination. See the wrap-up below 👇.
Additionally, this PR makes sqlglot a regular dependency. (Added it under
[tool.poetry.dependencies]and removed everywhere else.poetry lock --no-updateis ran to update the lock file.)Related Issues
Additional Context
SQLAlchemy
For the sqlalchemy destination, we set the dialect based on the
backend_nameof the connection string. As shown below, most of the time thebackend_nameand the dialect string match, but sometimes they slightly differ (i.e.postgresqlandpostgres).External dialects maintained by SQLAlchemy:
awsathenaathenaredshiftredshiftdrilldrilldruiddruidpresto, hive, trinopresto, hive, trinoclickhouseclickhousedatabricksdatabricksbigquerybigquerymssqltsqlsnowflakesnowflaketeradatasqlteradataInternal dialects:
mssqltsqlmysqlmysqloracleoraclepostgresqlpostgressqlitesqliteAll other destinations
"athena""bigquery""clickhouse""databricks""duckdb""duckdb""tsql""postgres""redshift""snowflake""tsql"(previously noted as working)"presto"(previously noted as working)-"duckdb"(previously noted as working)"n/a""n/a""n/a"