drop python 3.8, enable python 3.13 and enable linting and common tests for 3.12, 3.13 #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
force-pushed
the
tmp/test_py_versions
branch
3 times, most recently
from
368e04d to
d0de684
Compare
sh-rp
changed the title
sh-rp
changed the title
sh-rp
force-pushed
the
tmp/test_py_versions
branch
from
d0de684 to
8cc3b7a
Compare
sh-rp
changed the title
sh-rp
changed the title
sh-rp
force-pushed
the
tmp/test_py_versions
branch
2 times, most recently
from
5e4f829 to
fc4006c
Compare
sh-rp
commented
Jan 8, 2025
| requests = ">=2.26.0" | ||
| pendulum = ">=2.1.2" | ||
| # TODO: pin to tag on dlt-pendulum repo | ||
| dlt-pendulum = [ |
There was a problem hiding this comment.
NOTE: this still requires cargo at this point
There was a problem hiding this comment.
@rudolfix I have another question about this: should we not have a different package name for our pendulum? The way it is currently set up, dlt-pendulum is always used, also for python versions before 3.13, this means there will be package name collissions if users also have the regular pendulum in their dependencies already in a project. I'm not sure what happens in this case.
Also you mentioned that you made some changes they will not like and there is a change in the code where you removed the casting of pendulum.now() to a string, are the libraries now incompatible?
sh-rp
force-pushed
the
tmp/test_py_versions
branch
from
8358de4 to
2b727ee
Compare
sh-rp
force-pushed
the
tmp/test_py_versions
branch
from
7f22437 to
e46f21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
Based on #2047
ToDo: