Response detections #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far addresses some of the points in #5
Detect payload schema by comparing response schema with all other endpoints: https://github.com/dlt-hub/dlt-init-openapi/blob/response-detections/openapi_python_client/parser/responses.py#L32
Works pretty well so far, but found some cases where it picks the wrong path
Some improvements detecting list/single item endpoints. Lot of that comes from 1.
Currently have basic detection for offset and cursor pagination. Only using property name and types for this atm, looking for the least nested property matching "cursor", etc. https://github.com/dlt-hub/dlt-init-openapi/blob/response-detections/openapi_python_client/parser/pagination.py#L1
Transformers with multiple path params supported. Only when all path params resolve to corresponding properties in parent schema
Fix resource/transformer arguments order, remove pagination args