feat: Enable synchronization with history + give access to location in onError #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will default to true. When false, and before, we would sometimes have situations that would be a little weird for end users. An example of this is when having a slow connection and clicking on first one link and then another before loading has completed. This would before result in two entires in the history stack, meaning that when we come to the page for our second link and then go back we would not go to the page we started at but rather the first link. Also added in this feat is the possibility to reset the URL in the browser when aborting, something that will be enabled by default when syncWithHistory is true and no custom onAborted is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
feat: Provide the location for which an error occurred in onError
feat: New option, syncWithHistory, that will manage the history stack
Will default to true.
When false, and before, we would sometimes have situations that would be a little weird for end users. An example of this is when having a slow connection and clicking on first one link and then another before loading has completed. This would before result in two entires in the history stack, meaning that when we come to the page for our second link and then go back we would not go to the page we started at but rather the first link.
Also added in this feat is the possibility to reset the URL in the browser when aborting, something that will be enabled by default when
syncWithHistoryis true and no customonAbortedis defined.