-
-
Notifications
You must be signed in to change notification settings - Fork 232
ci: Re-enable GDC workflow #3009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5109296 bin/dub
-rough build time=62s
+rough build time=61s Full build output
|
Wonderful |
Raise bug reports. ;-) |
@ibuclaw : I don't have an account. You can easily reproduce with: $ podman run --rm -it alpine:edge
$ apk add --no-cache bash build-base curl curl-dev dtools dub git grep rsync gcc-gdc
$ git clone https://github.com/dlang-community/D-YAML.git
$ cd D-YAML
$ dub test --compiler=gdc ICE is:
And relevant packages:
|
@Geod24 given the location of the ICE, I guess you can compile with https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119817 In within hours of gcc-15.1 being branched for release. |
Good catch (and timing)! |
Also slightly modify unittest code to work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119817
Somewhat hidden but this fixes diff --git i/test/dub-as-a-library-cwd/subproject/dub.sdl w/test/dub-as-a-library-cwd/subproject/dub.sdl
index cb896c94..d1c5119c 100644
--- i/test/dub-as-a-library-cwd/subproject/dub.sdl
+++ w/test/dub-as-a-library-cwd/subproject/dub.sdl
@@ -1 +1,2 @@
name "subproject"
+buildRequirements "allowWarnings" |
For |
@the-horo : Thanks! I might hop on an Alpine later and try to reproduce locally. Although in that instance I would like to know what the warning is before disabling it. Likewise, for cimportpath, is it genuinely broken or it's just testing a functionality that GDC doesn't have ? |
I also would like to look into #2938 |
Regarding warnings, I had the start of a fix in #2324 |
And, like you said in the other issue, since dub adds -Werror by default and gdc treats deprecations as warnings this leads to the compiler invocation failing.
gdc doesn't support
So skipping the test is appropriate.
Fighting against the unittest runner myself and slowly going through flaky-tests vs genuinely unsupported gdc stuff. My main issue are the warnings (esp with gdc-15). I thought that |
Something majorly funky appears to be going on here. @ibuclaw any ideas? |
From https://gcc.gnu.org/onlinedocs/gcc-15.1.0/gdc/ImportC.html:
|
No description provided.