Fix error message location for incompatible function arguments #21264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #21167
So the error message should point to the line with the problematic argument rather than the line where the function call starts.
So here's what I did -
callMatch
function intypesem.d
to pass the argument's location to the error helperexpressionsem.d
andfuncsem.d
to accept and use the argument's location also updated thefunctionResolve
function intemplatesem.d
to accept the modified error helper delegatefail_compilation/fix21167.d
to verify the fix