Remove the peculiar FarForceDataUpdate file and logic#158
Open
siimav wants to merge 1 commit intodkavolis:masterfrom
Open
Remove the peculiar FarForceDataUpdate file and logic#158siimav wants to merge 1 commit intodkavolis:masterfrom
siimav wants to merge 1 commit intodkavolis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm honestly perplexed about what this was supposed to achieve. It will invalidate MM cache twice in a row and after that the patch file does absolutely nothing. There isn't anything checking for the existence of that cfg anywhere else in code either.
With the recent CKAN updates, it has however caused the mod to be reinstalled over and over as described in #152-