Add f_type field to struct statvfs #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been added in both glibc and musl. Glibc has been zeroing out the spare ints since the dawn of time and musl since at least 1.0.0, so it's safe to simply check if these values are nonzero.
|
Thanks for this. I'm not sure what's going on with the test failures on Windows. Edit: Needed to update mkmf-lite for JRuby, now it works. |
djberg96
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been added in both glibc and musl. Glibc has been zeroing out the spare ints since the dawn of time and musl since at least 1.0.0, so it's safe to simply check if these values are nonzero.
bminor/glibc@92861d9
bminor/musl@7291c6c