fix: django conf should not be modified#341
Closed
techblack wants to merge 2 commits intodjango:mainfrom
Closed
Conversation
|
Also affected by this bug. Would love to see this get merged in soon. |
Member
|
I'm planning releases for the new year period. This is on the agenda for that. |
sevdog
suggested changes
Feb 24, 2023
Contributor
sevdog
left a comment
There was a problem hiding this comment.
This should work like pubsub layer, if a deepcopy is realy needed it should also be addressed also in that layer.
Co-authored-by: Devid <setti.davide89@gmail.com>
sevdog
approved these changes
Feb 27, 2023
Member
|
Resolved in #352. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This place is passed by reference, which will cause the configuration to change, and other applications will read the wrong configuration
before this pr:
from django.conf import settings getattr(settings, "CHANNEL_LAYERS", {})result
{'default': {'BACKEND': 'channels_redis.core.RedisChannelLayer', 'CONFIG': {'hosts': [{'sentinels': [('a.b.c.d', 6379)], 'master_name': 'redis-master', 'db': 0, 'password': 'password', 'sentinel_kwargs': {'password': 'password'}}]}}}after channel connection result
{'default': {'BACKEND': 'channels_redis.core.RedisChannelLayer', 'CONFIG': {'hosts': [{'db': 0, 'password': 'password'}]}}}