Add data sanitization to RequestPanel #2103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `SANITIZE_REQUEST_DATA` setting to control sanitization of request data. - Implemented `sanitize_value` function to sanitize sensitive data based on key patterns. - Updated `get_sorted_request_variable` to support sanitization. - Added tests for sanitization of GET, POST, cookies, and session data. - Updated documentation to include new settings. django-commons#2074
Added test for completeness, as we already have tests for GET and POST parameter data sanitization, but were missing a test for cookie data.
matthiask
reviewed
Mar 12, 2025
There was a problem hiding this comment.
It's a great start! Thank you.
I'd like you to investigate whether it's possible to use the SafeExceptionReporterFilter instead of duplicating the filtering and cleaning logic ourselves, especially the list of patterns. The list of patterns isn't updated often in Django but it does happen from time to time, and if we can just reuse the functionality in there we immediately profit as well without doing anything.
- Moved import of `dt_settings` to the top of the file. - Simplified session data sanitization logic by avoiding duplicate code.
@matthiask will do. Thanks. |
|
I will be opening a new PR soon with a new approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implementation:
SANITIZE_REQUEST_DATAsetting to control sanitization of request data.REQUEST_SANITIZATION_PATTERNSsetting to definekeypatterns to sanitize the respectivevalue.sanitize_valuefunction to sanitize sensitive data based onkeyregex patterns.get_sorted_request_variableto support sanitization.Fixes #2074
Checklist:
docs/changes.rst.