Commas are illegal in GHA cache keys #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1100, we started building `divviup_api_integration_test` with feature `admin`. This breaks `docker-release.yml`, because the Rust features are used to construct GH Actions cache keys, and commas are illegal there (at the very least, `docker buildx build --cache-from` doesn't like it). Construct the cache key by joining with `-` to work `around this. Additionally, this _should_ have broken `docker.yml`, but I forgot to add the `admin` feature there, which this PR corrects. Part of #1096
branlwyd
approved these changes
Jun 14, 2024
divergentdave
approved these changes
Jun 14, 2024
.github/workflows/docker.yml
Outdated
| @@ -10,12 +10,16 @@ jobs: | |||
| build_docker: | |||
| strategy: | |||
| matrix: | |||
| rust-features: ["default", "integration-testing"] | |||
| rust-features: [["default"], ["integration-testing"] , [admin"]] | |||
There was a problem hiding this comment.
nit: typo
Suggested change
| rust-features: [["default"], ["integration-testing"] , [admin"]] | |
| rust-features: [["default"], ["integration-testing", "admin"]] |
tgeoghegan
force-pushed
the
timg/docker-cache-commas
branch
from
8f5a8f0 to
2c835ff
Compare
|
Oh, shoot, this let me merge despite the test failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1100, we started building
divviup_api_integration_testwith featureadmin. This breaksdocker-release.yml, because the Rust features are used to construct GH Actions cache keys, and commas are illegal there (at the very least,docker buildx build --cache-fromdoesn't like it). Construct the cache key by joining with-to work `around this.Additionally, this should have broken
docker.yml, but I forgot to add theadminfeature there, which this PR corrects.Part of #1096