Skip to content

Fix fallback in getStreamURL to avoid fake rate limit when streamLink returns null #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix fallback in getStreamURL to avoid fake rate limit when streamLink returns null #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b9013
fix-sc
A7aneekxd Jul 3, 2025
200e6d0
fix-soundcloud
A7aneekxd Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 42 additions & 12 deletions packages/soundcloud/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,20 +121,50 @@ export class SoundCloudPlugin extends ExtractorPlugin {
return related.filter(t => t.title).map(t => new SoundCloudSong(this, t));
}

async getStreamURL<T>(song: SoundCloudSong<T>) {
if (!song.url) {
throw new DisTubeError("SOUNDCLOUD_PLUGIN_INVALID_SONG", "Cannot get stream url from invalid song.");
}
const stream = await this.soundcloud.util.streamLink(song.url);
if (!stream) {
throw new DisTubeError(
"SOUNDCLOUD_PLUGIN_RATE_LIMITED",
"Reached SoundCloud rate limits\nSee more: https://developers.soundcloud.com/docs/api/rate-limits#play-requests",
);
}
return stream;
async getStreamURL(song) {
if (!song.url) {
throw new import_distube.DisTubeError("SOUNDCLOUD_PLUGIN_INVALID_SONG", "Cannot get stream url from invalid song.");
}

let stream = await this.soundcloud.util.streamLink(song.url).catch(() => null);

if (stream) return stream;

const track = await this.soundcloud.resolve.get(song.url, true).catch(() => null);

if (!track || !track.media || !track.media.transcodings?.length) {
throw new import_distube.DisTubeError("SOUNDCLOUD_PLUGIN_STREAM_ERROR", "Invalid or restricted SoundCloud track.");
}


const progressive = track.media.transcodings.find(t => t.format.protocol === "progressive");
const transcoding = progressive || track.media.transcodings[0];

if (!transcoding?.url) {
throw new import_distube.DisTubeError("SOUNDCLOUD_PLUGIN_STREAM_ERROR", "No valid stream URL found.");
}

const clientId = await this.soundcloud.api.getClientId().catch(() => null);
if (!clientId) {
throw new import_distube.DisTubeError("SOUNDCLOUD_PLUGIN_NO_CLIENT_ID", "Missing client ID");
}

const res = await fetch(`${transcoding.url}?client_id=${clientId}`);
if (!res.ok) {
throw new import_distube.DisTubeError(
"SOUNDCLOUD_PLUGIN_RATE_LIMITED",
`Failed to fetch stream URL. HTTP ${res.status}`
);
}

const json = await res.json();
if (!json?.url) {
throw new import_distube.DisTubeError("SOUNDCLOUD_PLUGIN_STREAM_ERROR", "Stream URL missing in response.");
}

return json.url;
}

async searchSong<T>(query: string, options: ResolveOptions<T>) {
const songs = await this.search(query, SearchType.Track, 1, options);
return songs[0];
Expand Down