Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity check of (u,v) units #225

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Add sanity check of (u,v) units #225

merged 2 commits into from
Aug 22, 2024

Conversation

jeffjennings
Copy link
Collaborator

@jeffjennings jeffjennings commented Aug 22, 2024 •
edited
Loading

People often pass in u and v coordinates in [m], then either the fit fails or they get confused by the fit results. This PR:

  • adds a function to check the units and issue a warning if they appear to be in [m] rather than the expected [lambda].
  • adds the check to the pipeline in fit.py

@jeffjennings jeffjennings requested a review from rbooth200 August 22, 2024 15:39
@jeffjennings jeffjennings mentioned this pull request Aug 22, 2024
Merged
@jeffjennings jeffjennings merged commit 029378e into master Aug 22, 2024
7 checks passed
@jeffjennings jeffjennings deleted the uv_unit_check branch August 22, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbooth200 rbooth200 rbooth200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffjennings @rbooth200