Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debris interfacing #195

Merged
merged 18 commits into from
Jul 4, 2023
Merged

Debris interfacing #195

merged 18 commits into from
Jul 4, 2023

Conversation

jeffjennings
Copy link
Collaborator

@jeffjennings jeffjennings commented Nov 16, 2022

Adds functionality for running fits with scale height inference from the terminal.

@jeffjennings jeffjennings changed the title Debris interfacing/tutorial [WIP] Debris interfacing/tutorial Feb 14, 2023
@jeffjennings jeffjennings marked this pull request as draft March 2, 2023 06:58
@jeffjennings jeffjennings changed the title [WIP] Debris interfacing/tutorial Debris interfacing/tutorial Jul 3, 2023
@jeffjennings jeffjennings changed the title Debris interfacing/tutorial Debris interfacing\ Jul 3, 2023
@jeffjennings jeffjennings changed the title Debris interfacing\ Debris interfacing Jul 3, 2023
@jeffjennings jeffjennings marked this pull request as ready for review July 4, 2023 12:59
@jeffjennings jeffjennings requested a review from rbooth200 July 4, 2023 13:16
rbooth200
rbooth200 previously approved these changes Jul 4, 2023
@rbooth200
Copy link
Collaborator

Looks good, happy to merge. My only comment is that it's valid to fit a debris disc with the log-normal model, we just don't have a way of evaluating whether the choice of h is good. I haven't tested it much though, so I don't know if the fitting with the log-normal method is working at all with the debris fitter

@jeffjennings
Copy link
Collaborator Author

Ok great, thank you. I've changed fit.py to not force method to Normal, just print a warning.

@jeffjennings jeffjennings merged commit f55a412 into master Jul 4, 2023
@jeffjennings jeffjennings deleted the debris_interface branch July 4, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants