Skip to content

fix(GuildChannel): Handle empty overwrite must only handle @everyone #11221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −7
Open

fix(GuildChannel): Handle empty overwrite must only handle @everyone #11221

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f613f57
Add check overwrite id
vakiliner Oct 24, 2025
cd0396d
Merge branch 'discordjs:main' into permissionsLocked
vakiliner Oct 27, 2025
39edaf2
Update GuildChannel.js
vakiliner Oct 27, 2025
fa61308
Update GuildChannel.js
vakiliner Oct 27, 2025
6b23cee
chore: fmt
vakiliner Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/discord.js/src/structures/GuildChannel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,27 +116,29 @@ class GuildChannel extends BaseChannel {
* @readonly
*/
get permissionsLocked() {
if (!this.parent) return null;
const { parent } = this;
if (!parent) return null;

// Get all overwrites
const overwriteIds = new Set([
...this.permissionOverwrites.cache.keys(),
...this.parent.permissionOverwrites.cache.keys(),
...parent.permissionOverwrites.cache.keys(),
]);

// Compare all overwrites
return [...overwriteIds].every(key => {
const channelVal = this.permissionOverwrites.cache.get(key);
const parentVal = this.parent.permissionOverwrites.cache.get(key);
const parentVal = parent.permissionOverwrites.cache.get(key);

// Handle empty overwrite
if (
(!channelVal &&
key === this.guildId &&
((!channelVal &&
parentVal.deny.bitfield === PermissionsBitField.DefaultBit &&
parentVal.allow.bitfield === PermissionsBitField.DefaultBit) ||
(!parentVal &&
channelVal.deny.bitfield === PermissionsBitField.DefaultBit &&
channelVal.allow.bitfield === PermissionsBitField.DefaultBit)
(!parentVal &&
channelVal.deny.bitfield === PermissionsBitField.DefaultBit &&
channelVal.allow.bitfield === PermissionsBitField.DefaultBit))
) {
return true;
}
Expand Down