Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(ModalSubmitFields): fix fields type #10816

Merged
merged 2 commits into from
Mar 30, 2025
Merged

types(ModalSubmitFields): fix fields type #10816

merged 2 commits into from
Mar 30, 2025

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #10815

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza added this to the discord.js 15.0.0 milestone Mar 25, 2025
@sdanialraza sdanialraza requested a review from a team as a code owner March 25, 2025 22:28
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 30, 2025 11:41am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 30, 2025 11:41am

@Jiralite Jiralite requested a review from Copilot March 26, 2025 18:15
Copilot
Copilot AI reviewed Mar 26, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@kodiakhq kodiakhq bot merged commit 432aba3 into discordjs:main Mar 30, 2025
7 checks passed
@sdanialraza sdanialraza deleted the types/fix-modal-submit-fields branch March 30, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
backport-candidate packages:discord.js semver:patch typings
Projects
discord.js
Status: Done
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.

Incorrect type for ModalSubmitFields.fields
4 participants
@sdanialraza @vladfrangu @Jiralite @Qjuh