Skip to content

fix: don't set ready status twice #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented Mar 18, 2025

Please describe the changes this PR makes and why it should be merged:

Client#_triggerClientReady() already sets status to Ready, so it was set redundantly before calling it.

Status and versioning classification:

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 6:07pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Apr 17, 2025 6:07pm

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 17, 2025
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Apr 17, 2025
@kodiakhq kodiakhq bot merged commit feec5ef into discordjs:main Apr 17, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 17, 2025
@Qjuh Qjuh deleted the fix/redundant-ready branch May 14, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants