Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add undefined to flags for exactOptionalPropertyTypes #10707

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Explicitly adds undefined to flags to resolve issues when using the exactOptionalPropertyTypes compiler option.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza requested a review from a team as a code owner January 16, 2025 18:11
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 6:12pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 6:12pm

@kodiakhq kodiakhq bot merged commit 2109688 into discordjs:main Jan 16, 2025
7 checks passed
@sdanialraza sdanialraza deleted the types/add-undefined-flags branch January 16, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants