refactor!: Return only snowflakes for bulk delete #10704
Merged
+14
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Bulk deleting will only return the message ids that were deleted.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
approved these changes
Jan 15, 2025
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Almeida <[email protected]>
SpaceEEC
approved these changes
Jan 15, 2025
vladfrangu
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to add
undefinedas a return type per #8410. This was because when message ids are supplied and deleted, they are attempted to be resolved from the cache. This removes the cache hit, and will now only return the ids that were removed. Users will have access to the messages they have cached before running this method anyway.