Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: move crosspost() to GuildMessageManager #10703

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix!: move crosspost() to GuildMessageManager #10703

merged 1 commit into from
Jan 15, 2025

Conversation

sdanialraza
Copy link
Contributor

@sdanialraza sdanialraza commented Jan 14, 2025 •
edited by almeidx
Loading

Please describe the changes this PR makes and why it should be merged:
Moved MessageManager#crosspost() to GuildMessageManager as messages can't be crossposted to DMs. The typings already had the crosspost method under GuildMessageManager and didn't need updating.

BREAKING CHANGE: The crosspost() method from MessageManager has been moved to GuildMessageManager.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@sdanialraza sdanialraza requested a review from a team as a code owner January 14, 2025 20:17
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Jan 14, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jan 14, 2025 8:19pm
discord-js-guide ⬜️ Ignored (Inspect) Jan 14, 2025 8:19pm

@almeidx almeidx merged commit 6a42c5f into discordjs:main Jan 15, 2025
9 checks passed
@sdanialraza sdanialraza deleted the fix/move-crosspost-guild-message-manager branch January 15, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@Jiralite Jiralite Jiralite approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet kyranet approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:major
Projects
discord.js
Status: Done
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sdanialraza @vladfrangu @kyranet @SpaceEEC @Jiralite @almeidx