fix(PresenceUpdate): correctly add user regardless of their properties #10672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Qjuh
reviewed
Jan 1, 2025
SpaceEEC
approved these changes
Jan 12, 2025
monbrey
approved these changes
Jan 12, 2025
vladfrangu
approved these changes
Jan 13, 2025
Jiralite
pushed a commit
that referenced
this pull request
Jan 13, 2025
#10672) * fix(PresenceUpdate): correctly add user regardless of their properties * refactor(PresenceUpdate): reflect partials * refactor(PresenceUpdate): prettier * refactor(PresenceUpdate): add import --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Using this code, after 1 minute (sweeper time), any event for users that were cached and then swiped will not be fired anymore, this is due to user not being created in cache at all even though it can be fully partial as types for
newPresencestate, this adds user regardless of the data and allows event to be fired (similarly how it adds for guild emojis).Status and versioning classification: