Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SimpleIdentifyThrottler): don't sleep negative amounts #10669

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

didinele
Copy link
Member

No description provided.

@didinele didinele added this to the ws 2.1.0 milestone Dec 30, 2024
@didinele didinele requested a review from a team as a code owner December 30, 2024 18:50
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 7:29pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 7:29pm

@didinele didinele force-pushed the fix/negative-ws-timeouts branch from bec3b80 to adaf21e Compare December 30, 2024 18:55
@didinele didinele force-pushed the fix/negative-ws-timeouts branch from adaf21e to 3ca2591 Compare December 30, 2024 19:28
@didinele didinele force-pushed the fix/negative-ws-timeouts branch from 3ca2591 to 2d7fb90 Compare December 30, 2024 19:29
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.20%. Comparing base (0848fc6) to head (2d7fb90).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10669      +/-   ##
==========================================
+ Coverage   37.06%   37.20%   +0.14%     
==========================================
  Files         239      239              
  Lines       15206    15147      -59     
  Branches     1373     1373              
==========================================
  Hits         5636     5636              
+ Misses       9559     9500      -59     
  Partials       11       11              
Flag Coverage Δ
ws 34.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit b854c7b into main Dec 31, 2024
25 checks passed
@kodiakhq kodiakhq bot deleted the fix/negative-ws-timeouts branch December 31, 2024 18:16
@Jiralite Jiralite modified the milestones: ws 2.1.0, ws 3.0.0 Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants