Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Client): add request soundboard sounds #10608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Adds iterator and non-iterator variants for requesting soundboard sounds for core

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 4:20pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 4:20pm

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.36%. Comparing base (0374079) to head (9752195).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
packages/util/src/functions/groupBy.ts 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10608      +/-   ##
==========================================
- Coverage   38.18%   37.36%   -0.83%     
==========================================
  Files         239      240       +1     
  Lines       15563    15351     -212     
  Branches     1376     1384       +8     
==========================================
- Hits         5943     5736     -207     
+ Misses       9605     9600       -5     
  Partials       15       15              
Flag Coverage Δ
builders 80.38% <ø> (-2.06%) ⬇️
proxy 64.63% <ø> (-1.65%) ⬇️
rest 86.96% <ø> (-0.41%) ⬇️
util 49.42% <82.35%> (+7.99%) ⬆️
ws 34.45% <ø> (-1.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/core/src/client.ts Show resolved Hide resolved
packages/core/src/client.ts Show resolved Hide resolved
packages/core/src/client.ts Show resolved Hide resolved
@Jiralite Jiralite requested a review from kyranet November 19, 2024 22:38
@sdanialraza sdanialraza force-pushed the feat/add-request-soundboard-sounds branch 2 times, most recently from 3af60d9 to af803db Compare November 24, 2024 15:35
@sdanialraza sdanialraza force-pushed the feat/add-request-soundboard-sounds branch from af803db to 9752195 Compare November 24, 2024 16:20
@sdanialraza sdanialraza marked this pull request as ready for review November 26, 2024 12:54
@sdanialraza sdanialraza requested review from a team as code owners November 26, 2024 12:54
@Jiralite Jiralite added this to the core 3.0.0 milestone Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

3 participants