chore: address TODO

discordjs · Oct 9, 2024 · 73f3d33 · 73f3d33
1 parent 9bf295b
commit 73f3d33
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/discord.js/src/structures/VoiceChannelEffect.js b/packages/discord.js/src/structures/VoiceChannelEffect.js
@@ -31,10 +31,9 @@ class VoiceChannelEffect {
      */
     this.emoji = data.emoji ? new Emoji(guild.client, data.emoji) : null;
 
-    // TODO: Revise after discord-api-types.
     /**
      * The animation type of the effect.
-     * @type {?number}
+     * @type {?VoiceChannelEffectSendAnimationType}
      */
     this.animationType = data.animation_type ?? null;
 

diff --git a/packages/discord.js/src/util/APITypes.js b/packages/discord.js/src/util/APITypes.js
@@ -589,6 +589,11 @@
  * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/VideoQualityMode}
  */
 
+/**
+ * @external VoiceChannelEffectSendAnimationType
+ * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/VoiceChannelEffectSendAnimationType}
+ */
+
 /**
  * @external WebhookType
  * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/WebhookType}

diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts
@@ -166,6 +166,7 @@ import {
   GuildScheduledEventRecurrenceRuleFrequency,
   GatewaySendPayload,
   GatewayDispatchPayload,
+  VoiceChannelEffectSendAnimationType,
 } from 'discord-api-types/v10';
 import { ChildProcess } from 'node:child_process';
 import { EventEmitter } from 'node:events';
@@ -3562,8 +3563,7 @@ export class VoiceChannelEffect {
   public channelId: Snowflake;
   public userId: Snowflake;
   public emoji: Emoji | null;
-  // TODO: Revise after discord-api-types.
-  public animationType: 0 | 1 | null;
+  public animationType: VoiceChannelEffectSendAnimationType | null;
   public animationId: number | null;
   public soundId: Snowflake | number | null;
   public soundVolume: number | null;