Skip to content

Let config.stage accept an element or a string #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ccoenen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Let config.stage accept an element or a string #3

ccoenen wants to merge 2 commits into from

Conversation

@ccoenen
Copy link

@ccoenen ccoenen commented May 15, 2012

Originally, you have to initialise with the ID-String of the desired element. With this patch, you may also specify a DOM-Element.

Advantages:

  • no need for IDs for everything
  • Traqball can be initialised on elements that are not yet inserted into the dom.

@ccoenen
Copy link
Author

ccoenen commented May 15, 2012

actually the patch request is just for cbe2d93, the other one has its own Pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ccoenen