Track elements with respect to the original rect #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides better support for animations which can change an element's location on the screen.
This allows the rect to change on window resize, for example
…rt-checker # Conflicts: # dist/jquery.viewportchecker.min.js # dist/jquery.viewportchecker.min.js.map # src/jquery.viewportchecker.js
AdmDevSincro
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say you're using this library to add an animation to an element when it scrolls into/out of view. You choose a slide animation; the element will slide in from the bottom.
The element scrolls into view. The animation starts. The first keyframe puts the element lower than where it started.
Now the element is out of view, so the
classToAddis removed, and the callback is called. Now the element is in view.The element flickers into eternity.