Feature/118 optional customer table relation#119
Feature/118 optional customer table relation#119amulaj wants to merge 7 commits intodirections4partners:mainfrom
Conversation
…8-optional-customer-table-relation
|
|
There was a problem hiding this comment.
Pull request overview
This pull request introduces optional integration with Microsoft Sales Customer records for the CCMS customer table and implements a lazy-loading pattern for setup record retrieval. The implementation diverges from the original issue request by using a lookup-based approach with data population instead of a TableRelation property.
Changes:
- Added a "Use Microsoft Sales Customer" boolean field to the setup table and page to control the integration feature
- Implemented customer data lookup and population from Microsoft Sales Customer records through OnLookup trigger and supporting procedures
- Replaced direct CCMSSetup.Get() calls with a custom GetCCMSSetup() lazy-loading method
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| CCMS/src/Setup/D4PBCSetup.table.al | Adds "Use Microsoft Sales Customer" configuration field to control integration |
| CCMS/src/Setup/D4PBCSetup.page.al | Exposes new configuration field in the setup page UI |
| CCMS/src/Customer/D4PBCCustomer.table.al | Implements lookup-based integration with Microsoft Sales Customer and custom setup loading pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Pls. resolve and sign the CLA, thanks |
|
@freddydk the CLA is now signed and the PR comments resolved. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 participants
This pull request introduces integration with Microsoft Sales Customer records in the CCMS customer table and improves the setup record loading pattern. The main changes enable users to look up and populate customer data from Microsoft Sales Customers, add a new configuration option to control this feature, and optimize how setup data is accessed.
Integration with Microsoft Sales Customer:
"Use Microsoft Sales Customer"to theD4P BC Setuptable and page, allowing administrators to enable or disable Microsoft Sales Customer integration. [1] [2]LookupSalesCustomerprocedure, which opens a lookup dialog for Microsoft Sales Customers and populates the CCMS customer record with selected data if the feature is enabled. [1] [2]PopulateFromSalesCustomerprocedure to copy relevant fields from a Microsoft Sales Customer record to the current CCMS customer record.Setup record loading improvements:
CCMSSetup.Get()with a newGetCCMSSetup()procedure that uses lazy-loading to avoid redundant setup record retrievals. [1] [2] [3] [4]Namespace and dependency updates:
using Microsoft.Sales.Customer;statement to support Microsoft Sales Customer integration.Closes #118