Skip to content

feat: expose role prop on Input component for improved accessibility #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: expose role prop on Input component for improved accessibility #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmdk/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ const Separator = React.forwardRef<HTMLDivElement, SeparatorProps>((props, forwa
* All props are forwarded to the underyling `input` element.
*/
const Input = React.forwardRef<HTMLInputElement, InputProps>((props, forwardedRef) => {
const { onValueChange, ...etc } = props
const { onValueChange, role = "combobox", ...etc } = props
const isControlled = props.value != null
const store = useStore()
const search = useCmdk((state) => state.search)
Expand All @@ -807,7 +807,7 @@ const Input = React.forwardRef<HTMLInputElement, InputProps>((props, forwardedRe
autoCorrect="off"
spellCheck={false}
aria-autocomplete="list"
role="combobox"
role={role}
aria-expanded={true}
aria-controls={context.listId}
aria-labelledby={context.labelId}
Expand Down