Skip to content

Conversation

@tonyfarney
Copy link

@tonyfarney tonyfarney commented Sep 17, 2024

This improvement is important in order to allow setting aria attributes that need to be set (or override) to be WCAG compliant.

@vercel
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 5:26pm

@tonyfarney
Copy link
Author

@pacocoursey this improvement is important in order to allow setting aria attributes that need to be set (or override) to be WCAG compliant. Do you think this PR can be accepted and merged in the next few weeks?

@tonyfarney
Copy link
Author

At the time of this comment 3 out of 9 open PRs are about overriding components props. So I think it's indeed a need the community has. @pacocoursey please approve 1 of the PRs, or provide us the reason why you don't.

@LoicUV
Copy link

LoicUV commented Feb 28, 2025

It would also help overriding the autoComplete prop on the input, which is set to off right now.
Some browsers (including chrome) ignore this prop when set to off, resulting in the browser native panel showing above the command list. Setting this prop to a custom value can prevent this behavior.

@nathanael-ruf
Copy link

@pacocoursey Are you still maintaining this project?
If you don't have the capacity to do so, may I ask you to try and find another maintainer?
Maybe we can find a volunteer to help you out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants