fix: add bounds check before memcpy in ngx_http_vod_module.c#106
Open
orbisai0security wants to merge 1 commit into
Open
fix: add bounds check before memcpy in ngx_http_vod_module.c#106orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
ngx_http_vod_module.c.Vulnerability
V-001ngx_http_vod_module.c:856Description: At ngx_http_vod_module.c:856, ngx_memcpy copies original_buffer.len bytes from original_buffer.data into buffer_copy without verifying that the destination allocation is at least original_buffer.len bytes large. At line 935, part_count * sizeof(buffers[0]) bytes are copied without validating part_count against the allocated size of the buffers array. If an attacker can influence these length values through crafted MP4 or HLS input, they can overflow the heap buffer, overwriting adjacent heap metadata or allocations.
Changes
ngx_http_vod_module.cVerification
Automated security fix by OrbisAI Security