Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code ql evaluation 3 #4

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Code ql evaluation 3 #4

wants to merge 24 commits into from

Conversation

dingjiedanielyang-sec
Copy link
Owner

Test

@dingjiedanielyang-sec
Copy link
Owner Author

Test

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 19, 2022
View reviewed changes
purified.js
import { seal } from './utils.js';


var t = /<script type="application\/json">((.|\s)*?)<\/script>/;

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '<script type="application/json">' and containing many repetitions of ' '.
purified.js
}

export const isDevEnv = () => {
return apiHost() && apiHost().toLowerCase().includes('mydev.com');}

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[mydev.com](1)' can be anywhere in the URL, and arbitrary hosts may come before or after it.
purified.js

var t = /<script type="application\/json">((.|\s)*?)<\/script>/;

if(host && host.toLowerCase().includes('mydomain.com')){

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[mydomain.com](1)' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dingjiedanielyang-sec